Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17315#discussion_r106840206
--- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R ---
@@ -1354,9 +1354,8 @@ test_that("column functions", {
# passing option
df <- as.DataFrame(list(list("col" = "{\"date\":\"21/10/2014\"}")))
schema2 <- structType(structField("date", "date"))
- expect_error(tryCatch(collect(select(df, from_json(df$col, schema2))),
- error = function(e) { stop(e) }),
- paste0(".*(java.lang.NumberFormatException: For input
string:).*"))
+ s <- collect(select(df, from_json(df$col, schema2)))
+ expect_equal(s[[1]][[1]], NA)
--- End diff --
yea it's a minor bug fix, see https://github.com/cloud-fan/spark/pull/4
I'm not sure if it worth a ticket.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
