Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17353#discussion_r106841464
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala
---
@@ -202,14 +201,15 @@ object JoinReorderDP extends PredicateHelper {
}
/**
- * Builds a new JoinPlan if the two given sides can be joined with some
conditions.
+ * Builds a new JoinPlan if there exists at least one join condition
involving references from
+ * both left and right.
--- End diff --
```
Builds a new JoinPlan when both conditions hold
- the sets of items contained in both left and right sides do not overlap
- there exists at least one join condition involving references from both
sides
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
