Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2421#discussion_r17700696
  
    --- Diff: sbin/start-thriftserver.sh ---
    @@ -27,7 +27,7 @@ set -o posix
     FWDIR="$(cd "`dirname "$0"`"/..; pwd)"
     
     CLASS="org.apache.spark.sql.hive.thriftserver.HiveThriftServer2"
    -CLASS_NOT_FOUND_EXIT_STATUS=1
    +CLASS_NOT_FOUND_EXIT_STATUS=1024
    --- End diff --
    
    Please keep error codes < 128. From 
http://en.wikipedia.org/wiki/Exit_status:
    
        When a command terminates on a fatal signal whose number is N, Bash 
uses the value 128+N as the exit status.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to