Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/2294#issuecomment-55977479
Adding new methods to a trait is a break change. We can mark `Vector` and
`Matrix` as sealed, so no one can extend them. From Jenkins log:
~~~
[error] * method
transposeTimes(org.apache.spark.mllib.linalg.DenseVector)org.apache.spark.mllib.linalg.DenseVector
in trait org.apache.spark.mllib.linalg.Matrix does not have a correspondent in
old version
[error] filter with:
ProblemFilters.exclude[MissingMethodProblem]("org.apache.spark.mllib.linalg.Matrix.transposeTimes")
[error] * method
transposeTimes(org.apache.spark.mllib.linalg.DenseMatrix)org.apache.spark.mllib.linalg.DenseMatrix
in trait org.apache.spark.mllib.linalg.Matrix does not have a correspondent in
old version
[error] filter with:
ProblemFilters.exclude[MissingMethodProblem]("org.apache.spark.mllib.linalg.Matrix.transposeTimes")
[error] * method
times(org.apache.spark.mllib.linalg.DenseVector)org.apache.spark.mllib.linalg.DenseVector
in trait org.apache.spark.mllib.linalg.Matrix does not have a correspondent in
old version
[error] filter with:
ProblemFilters.exclude[MissingMethodProblem]("org.apache.spark.mllib.linalg.Matrix.times")
[error] * method
times(org.apache.spark.mllib.linalg.DenseMatrix)org.apache.spark.mllib.linalg.DenseMatrix
in trait org.apache.spark.mllib.linalg.Matrix does not have a correspondent in
old version
[error] filter with:
ProblemFilters.exclude[MissingMethodProblem]("org.apache.spark.mllib.linalg.Matrix.times")
[error] * method copy()org.apache.spark.mllib.linalg.Matrix in trait
org.apache.spark.mllib.linalg.Matrix does not have a correspondent in old
version
[error] filter with:
ProblemFilters.exclude[MissingMethodProblem]("org.apache.spark.mllib.linalg.Matrix.copy")
~~~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
