Github user ehsun7b commented on a diff in the pull request:
https://github.com/apache/spark/pull/17314#discussion_r107061443
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/r/AFTSurvivalRegressionWrapper.scala
---
@@ -30,6 +32,7 @@ import
org.apache.spark.ml.regression.{AFTSurvivalRegression, AFTSurvivalRegress
import org.apache.spark.ml.util._
import org.apache.spark.sql.{DataFrame, Dataset}
+@Since("2.0.0")
private[r] class AFTSurvivalRegressionWrapper private (
--- End diff --
OK,
We have added the annotations already and the versions are very precise
because we have developed a tool to find the exact version a class appeared in,
for the first time.
Should we remove the annotations from private classes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
