Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17350#discussion_r107073563
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ComplexTypeSuite.scala
---
@@ -251,6 +251,9 @@ class ComplexTypeSuite extends SparkFunSuite with
ExpressionEvalHelper {
}
test("StringToMap") {
+ val expectedDataType = MapType(StringType, StringType,
valueContainsNull = true)
+ assert(new StringToMap("").dataType === expectedDataType)
+
--- End diff --
I am fine to keep the test case here, but also call `checkEvaluation` to
verify the result, if you do not know how to add test cases to
`string-function.sql`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
