Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17302#discussion_r107091712
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
@@ -70,7 +70,20 @@ object RDDConversions {
object ExternalRDD {
def apply[T: Encoder](rdd: RDD[T], session: SparkSession): LogicalPlan =
{
- val externalRdd = ExternalRDD(CatalystSerde.generateObjAttr[T],
rdd)(session)
+ val attr = {
+ val attr = CatalystSerde.generateObjAttr[T]
+ // Since ExpressionEncoder[T].deserializer is not resolved here,
+ // cannot access ExpressionEncoder[T].deserializer.nullable.
+ // We infer nullability from DataType
+ attr.dataType match {
--- End diff --
can we move this logic to `CatalystSerde.generateObjAttr`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
