Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/17088#discussion_r107286200
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -1365,19 +1375,43 @@ class DAGScheduler(
*/
private[scheduler] def handleExecutorLost(
execId: String,
- filesLost: Boolean,
- maybeEpoch: Option[Long] = None) {
+ workerLost: Boolean): Unit = {
+ // if the cluster manager explicitly tells us that the entire worker
was lost, then
+ // we know to unregister shuffle output. (Note that "worker"
specifically refers to the process
+ // from a Standalone cluster, where the shuffle service lives in the
Worker.)
+ val filesLost = workerLost ||
!env.blockManager.externalShuffleServiceEnabled
+ removeExecutorAndUnregisterOutputs(
+ execId = execId,
+ fileLost = filesLost,
--- End diff --
The `fileLost` vs. `filesLost` naming difference is a little confusing --
is the distinction even conveying a difference worth paying attention to?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
