Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17361#discussion_r107307367
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/KeyedStateImpl.scala
 ---
    @@ -17,37 +17,45 @@
     
     package org.apache.spark.sql.execution.streaming
     
    +import java.sql.Date
    +
     import org.apache.commons.lang3.StringUtils
     
    -import org.apache.spark.sql.streaming.KeyedState
    +import org.apache.spark.sql.catalyst.plans.logical.{EventTimeTimeout, 
ProcessingTimeTimeout}
    +import org.apache.spark.sql.execution.streaming.KeyedStateImpl._
    +import org.apache.spark.sql.streaming.{KeyedState, KeyedStateTimeout}
     import org.apache.spark.unsafe.types.CalendarInterval
     
    +
     /**
      * Internal implementation of the [[KeyedState]] interface. Methods are 
not thread-safe.
      * @param optionalValue Optional value of the state
      * @param batchProcessingTimeMs Processing time of current batch, used to 
calculate timestamp
      *                              for processing time timeouts
    - * @param isTimeoutEnabled Whether timeout is enabled. This will be used 
to check whether the user
    - *                         is allowed to configure timeouts.
    + * @param timeoutConf   Type of timeout configured. Based on this, 
different operations will
    + *                        be supported.
    --- End diff --
    
    nit: indent is inconsistent


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to