Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17302#discussion_r107323158
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/object.scala
---
@@ -41,7 +41,20 @@ object CatalystSerde {
}
def generateObjAttr[T : Encoder]: Attribute = {
- AttributeReference("obj", encoderFor[T].deserializer.dataType,
nullable = false)()
+ val deserializer = encoderFor[T].deserializer
+ val dataType = deserializer.dataType
+ val nullable = if (deserializer.childrenResolved) {
--- End diff --
I know `resolveAndBind` will resolve it. But looks at the code snippet
above:
val deserializer = encoderFor[T].deserializer
val dataType = deserializer.dataType
val nullable = if (deserializer.childrenResolved) { // or
deserializer.resolved
I don't see you have a chance to call `resolveAndBind` here...
`encoderFor[T]` will call `assertUnresolved` on the encoder to return, it
is implemented like:
def assertUnresolved(): Unit = {
(deserializer +: serializer).foreach(_.foreach {
case a: AttributeReference if a.name != "loopVar" =>
sys.error(s"Unresolved encoder expected, but $a was found.")
case _ =>
})
}
It makes sure that both `deserializer` and `serializer` are unresolved.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
