Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17348#discussion_r107335293
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/DataFramePivotSuite.scala ---
    @@ -230,4 +230,17 @@ class DataFramePivotSuite extends QueryTest with 
SharedSQLContext{
             .groupBy($"a").pivot("a").agg(min($"b")),
           Row(null, Seq(null, 7), null) :: Row(1, null, Seq(1, 7)) :: Nil)
       }
    +
    +  test("pivot with timestamp and count should not print internal 
representation") {
    +    val ts = "2012-12-31 16:00:10.011"
    +    val tsWithZone = "2013-01-01 00:00:10.011"
    +
    +    withSQLConf(SQLConf.SESSION_LOCAL_TIMEZONE.key -> "GMT") {
    +      val df = 
Seq(java.sql.Timestamp.valueOf(ts)).toDF("a").groupBy("a").pivot("a").count()
    +      val expected = StructType(
    +        StructField("a", TimestampType) ::
    +        StructField(tsWithZone, LongType) :: Nil)
    --- End diff --
    
    the column name changes with timezone, but what about the value? can you 
also check the result?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to