Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/2294#discussion_r17709072 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala --- @@ -36,9 +37,42 @@ trait Matrix extends Serializable { /** Converts to a breeze matrix. */ private[mllib] def toBreeze: BM[Double] + /** Gets the i-th element in the array backing the matrix. */ + private[mllib] def apply(i: Int): Double --- End diff -- Maybe it is good to remove this method. Because it may cause confusion between DenseMatrix and SparseMatrix.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org