Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/17393#discussion_r107610921
--- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala ---
@@ -187,6 +187,7 @@ private[spark] class SecurityManager(
val ioEncryptionKey: Option[Array[Byte]] = None)
extends Logging with SecretKeyHolder {
+ def this(sparkConf: SparkConf) {this(sparkConf, None)}
--- End diff --
Add a blank line after. I think this is more conventional as
`def this(sparkConf: SparkConf) = this(sparkConf, None)`
Because this is private to Spark, is it really something you need to extend?
That is, is there a good case to make this an SPI of sorts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
