Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/17295#discussion_r107787099
--- Diff:
core/src/main/scala/org/apache/spark/storage/BlockManagerManagedBuffer.scala ---
@@ -31,17 +35,31 @@ import org.apache.spark.util.io.ChunkedByteBuffer
private[storage] class BlockManagerManagedBuffer(
blockInfoManager: BlockInfoManager,
blockId: BlockId,
- chunkedBuffer: ChunkedByteBuffer) extends
NettyManagedBuffer(chunkedBuffer.toNetty) {
+ data: BlockData,
+ dispose: Boolean) extends ManagedBuffer {
--- End diff --
Hmm, I prefer `dispose`, because it's not about needing to dispose the
buffer, but wanting to dispose the buffer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
