Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/17417#discussion_r108031807
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/Window.scala ---
@@ -113,12 +113,12 @@ object Window {
* Creates a [[WindowSpec]] with the frame boundaries defined,
* from `start` (inclusive) to `end` (inclusive).
*
- * Both `start` and `end` are relative positions from the current row.
For example, "0" means
+ * Both `start` and `end` are relative positions to the current row. For
example, "0" means
* "current row", while "-1" means the row before the current row, and
"5" means the fifth row
* after the current row.
*
- * We recommend users use `Window.unboundedPreceding`,
`Window.unboundedFollowing`,
- * and `Window.currentRow` to specify special boundary values, rather
than using integral
+ * We recommend users to use [[Window.unboundedPreceding]],
[[Window.unboundedFollowing]],
--- End diff --
"We recommend that users use" is correct, but 'that' can be omitted and
it's still correct.
I think the backticks are on purpose as many scaladoc refs like this also
cause doc failures. At least you need to verify this before changing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
