Github user facaiy commented on the issue:

    https://github.com/apache/spark/pull/17407
  
    @jkbradley Thanks. I agree with your advice. Modifying the value is a 
little aggressive, while changing ImpurityCalculator.getCalculator is more 
moderate. However, I'm afraid that the similar bugs, because of mismatch, won't 
leave if we don't fix it at first.
    
    By the way, some unit tests broken, through I have tested them before 
pushing. Perhaps there is some wrong with my IDE, and I need to take a check on 
next Monday.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to