Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/17430#discussion_r108046680
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -190,6 +190,7 @@ private[deploy] class SparkSubmitArguments(args:
Seq[String], env: Map[String, S
.orNull
numExecutors = Option(numExecutors)
.getOrElse(sparkProperties.get("spark.executor.instances").orNull)
+ queue =
Option(queue).orElse(sparkProperties.get("spark.yarn.queue")).getOrElse("default")
--- End diff --
instead of `.getOrElse("default")`, i think it should be `orNull` - we
don't know the default queue name of the system since it could change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
