Github user zero323 commented on the issue:
https://github.com/apache/spark/pull/17218
> True, we should do it for all models. And you're right that it's more
involved than I was thinking. Specifically, rather than calling setParams from
_create_model, I'd want us to call _copyValues from fit() in order to eliminate
duplicate code. Would you mind removing the Params from the model, and we can
work on adding them in more carefully for the next release? Thanks a lot!
>
> I dug up the existing JIRA for this issue:
https://issues.apache.org/jira/browse/SPARK-10931
I removed the code and I'll be following SPARK-10931. One possible
challenge (here and for parameters validation) is high latency of Py4j calls.
With large pipelines it can build up pretty fast.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
