Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17434#discussion_r108284608
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala 
---
    @@ -323,7 +323,7 @@ class SparkSession private(
        *  // |-- age: integer (nullable = true)
        *
        *  dataFrame.createOrReplaceTempView("people")
    -   *  sparkSession.sql("select name from people").collect.foreach(println)
    +   *  sparkSession.sql("select name from people").show
    --- End diff --
    
    I imagine this is an OK modification but it's not really a typo fix. I'd 
avoid changes that aren't fixing problems


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to