Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17442#discussion_r108519339
  
    --- Diff: docs/configuration.md ---
    @@ -1137,6 +1137,17 @@ Apart from these, the following properties are also 
available, and may be useful
         mapping has high overhead for blocks close to or below the page size 
of the operating system.
       </td>
     </tr>
    +<tr>
    +  
<td><code>spark.hadoop.mapreduce.fileoutputcommitter.algorithm.version</code></td>
    +  <td>1</td>
    +  <td>
    +    The file output committer algorithm version, valid algorithm version 
number: 1 or 2.
    +    Algorithm version 1 has a performance regression and algorithm version 
2 more
    --- End diff --
    
    This is a bit glass-is-half-empty. Is it maybe more neutral to say that 
option 2 may have better performance, but version 1 may handle failures better 
in certain situations, as per MAPREDUCE-4815.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to