Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17430#discussion_r108594377
  
    --- Diff: 
core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
    @@ -148,6 +148,17 @@ class SparkSubmitSuite
         appArgs.childArgs should be (Seq("--master", "local", "some", 
"--weird", "args"))
       }
     
    +  test("print the right queue name") {
    +    val clArgs = Seq(
    +      "--name", "myApp",
    +      "--class", "Foo",
    +      "--conf", "spark.yarn.queue=thequeue",
    +      "userjar.jar")
    +    val appArgs = new SparkSubmitArguments(clArgs)
    +    appArgs.queue should be ("thequeue")
    +    appArgs.toString.contains("thequeue") should be (true)
    --- End diff --
    
    @yaooqinn while you're here do you want to make this last change?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to