Github user zuotingbing commented on a diff in the pull request:
https://github.com/apache/spark/pull/17452#discussion_r108623175
--- Diff: R/check-cran.sh ---
@@ -40,7 +40,7 @@ fi
if [ -d "$SPARK_JARS_DIR" ]; then
# Build a zip file containing the source package with vignettes
- SPARK_HOME="${SPARK_HOME}" "$R_SCRIPT_PATH/"R CMD build $FWDIR/pkg
+ SPARK_HOME="${SPARK_HOME}" "$R_SCRIPT_PATH/"R CMD build "$FWDIR"/pkg
--- End diff --
Sure, but i do not think it is a good choice to quote whole arguments that
include a variable.
e.g. cp "/home/spark build/spark/conf/*.template" "/home/test" will
failed.
It seems to me that quote the variable is better than whole arguments,
what is your suggestion?
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
