Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/17434#discussion_r108632961
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -492,7 +492,7 @@ class AstBuilder extends SqlBaseBaseVisitor[AnyRef]
with Logging {
}
/**
- * Add an [[Aggregate]] to a logical plan.
+ * Add an [[Aggregate]] or [[GroupingSets]] to a logical plan.
--- End diff --
Didn't check the javadoc and the change follows `Aggregate`. I'll see how
to generate javadoc and check this out (as I've been meaning to do it anyway
for some time). Thanks for inspiration!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
