Github user kiszk commented on the issue: https://github.com/apache/spark/pull/17436 @sameeragarwal @cloud-fan could you review this except `SparkConf.scala` while there are four failures. They are not regressions. This is because `SparkConf.scala` is changed for tentatively enabling of off-heap. Before merging it master, I will revert the change in `SparkConf.scala`. Two failures due to tentative change in `SparkConf.scala` `org.apache.spark.SparkConfSuite.basic get and set` `org.apache.spark.deploy.rest.SubmitRestProtocolSuite.CreateSubmissionRequest` Two failures due to the original issues when `spark.memory.offHeap.enabled` is set to `true` ` org.apache.spark.FailureSuite.managed memory leak error should not mask other failures (SPARK-9266` ` org.apache.spark.sql.execution.UnsafeRowSerializerSuite.SPARK-10466: external sorter spilling with unsafe row serializer`
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org