Github user adrian-ionescu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17476#discussion_r108906608
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/CatalogFileIndex.scala
 ---
    @@ -111,7 +113,8 @@ private class PrunedInMemoryFileIndex(
         sparkSession: SparkSession,
         tableBasePath: Path,
         fileStatusCache: FileStatusCache,
    -    override val partitionSpec: PartitionSpec)
    +    override val partitionSpec: PartitionSpec,
    +    override val metadataOpsTimeNs: Option[Long])
    --- End diff --
    
    Add param doc, as it's not immediately obvious what a user is supposed to 
supply here.
    I'd say something like "time it took to obtain the partitionSpec from the 
Hive metastore", but maybe that's too specific..


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to