Github user sitalkedia commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17485#discussion_r109067135
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
    @@ -768,6 +767,19 @@ private[spark] class TaskSetManager(
           s" executor ${info.executorId}): ${reason.toErrorString}"
         val failureException: Option[Throwable] = reason match {
           case fetchFailed: FetchFailed =>
    +        if (!isZombie) {
    +          for (i <- 0 until numTasks if i != index) {
    +            // Only for the first occurance of the fetch failure, kill all 
running
    +            // tasks in the task set
    +            for (attemptInfo <- taskAttempts(i) if attemptInfo.running) {
    +              sched.backend.killTask(
    +                attemptInfo.taskId,
    +                attemptInfo.executorId,
    +                interruptThread = true,
    --- End diff --
    
    I see, @markhamstra, does it makes sense to do it only if 
spark.job.interruptOnCancel is enabled?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to