Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/17384#discussion_r109074309
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/IsotonicRegression.scala ---
@@ -84,7 +84,7 @@ private[regression] trait IsotonicRegressionBase extends
Params with HasFeatures
val extract = udf { v: Vector => v(idx) }
extract(col($(featuresCol)))
} else {
- col($(featuresCol))
+ col($(featuresCol)).cast(DoubleType)
--- End diff --
Precision loss may happen here. But I think we can not avoid it now, for we
use `mllib.IsotonicRegression` and the input dataframe is of type `input:
RDD[(Double, Double, Double)])`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
