Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/1486#discussion_r17768962
--- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskLocation.scala
---
@@ -22,13 +22,35 @@ package org.apache.spark.scheduler
* In the latter case, we will prefer to launch the task on that
executorID, but our next level
* of preference will be executors on the same host if this is not
possible.
*/
--- End diff --
Would you mind beefing up the documentation here a bit? I am having trouble
reading through and quickly finding out the difference between HostTaskLocation
and ExecutorCacheTaskLocation. I guess the latter is exclusively used for the
BlockManager cache, but it would be good to be explicit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
