GitHub user jerryshao opened a pull request:
https://github.com/apache/spark/pull/17495
[SPARK-20172] Add file permission check when listing files in
FsHistoryProvider
## What changes were proposed in this pull request?
In the current Spark's HistoryServer we expected to get
`AccessControlException` during listing all the files, but unfortunately it was
not worked because we actually doesn't check the access permission and no other
calls will throw such exception. What was worse is that this check will be
deferred until reading files, which is not necessary and quite verbose, since
it will be printed out the exception in every 10 seconds when checking the
files.
So here with this fix, we actually check the read permission during listing
the files, which could avoid unnecessary file read later on and suppress the
verbose log.
## How was this patch tested?
Add unit test to verify.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jerryshao/apache-spark SPARK-20172
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/17495.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17495
----
commit 10d254b4339d3e024f717e0f0666f996527bab23
Author: jerryshao <ss...@hortonworks.com>
Date: 2017-03-31T09:35:47Z
Add file permission check in listing files
Change-Id: I7c7014ed83dbba786d90ca530380e94c086b497b
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
