Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17459#discussion_r109817581
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/linalg/distributed/IndexedRowMatrixSuite.scala
---
@@ -89,11 +89,19 @@ class IndexedRowMatrixSuite extends SparkFunSuite with
MLlibTestSparkContext {
test("toBlockMatrix") {
val idxRowMat = new IndexedRowMatrix(indexedRows)
+
+ // Tests when n % colsPerBlock != 0
--- End diff --
This only tests a `IndexedRowMatrix` consisted of `DenseVector`. We should
add another test to test the cases of `SparseVector` and the mix of them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
