Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17537#discussion_r109889257
  
    --- Diff: 
core/src/test/scala/org/apache/spark/internal/config/ConfigEntrySuite.scala ---
    @@ -51,6 +52,26 @@ class ConfigEntrySuite extends SparkFunSuite {
         assert(conf.get(dConf) === 20.0)
       }
     
    +  test("conf entry: timezone") {
    --- End diff --
    
    also move this test to the end, it's weird to put this test in the middle 
of different config types tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to