Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/17296
High-level seems good now, though there are new conflicts in
`FPGrowthSuite` that need to be resolved.
Did you create a JIRA to track the broader issue of trying to make the
testing more generic?
Or at least - we could perhaps try to "enforce" the tests through a test
trait (e.g. `EstimatorModelTest`) with a test that takes generated data, fits
and performs the check. The trait could define an abstract `generateData`
method. Then each concrete test could implement the data generator - most have
some form of data generator method already anyway.
Of course we still need to ensure new tests implement the trait - but at
least if all existing test are adapted in this way it provides the blueprint
going forward.
The only other way I can think of would be via some reflection approach
(but the correct form of dataset needs to be generated for each estimator...)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
