Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/17527#discussion_r110064613
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -407,7 +408,7 @@ public UTF8String toLowerCase() {
}
private UTF8String toLowerCaseSlow() {
- return fromString(toString().toLowerCase());
+ return fromString(toString().toLowerCase(Locale.ROOT));
--- End diff --
It seems there are few cases exposed to users. For example, this seems used
in `Lower` and `InitCap` expressions, where, up to my knowledge, the lower
cased ones are exposed into users.
In this case, IIRC the same argument (consistent base + options for
variants approach) is applied in
[SPARK-18076](https://issues.apache.org/jira/browse/SPARK-18076). So, I think
it might be fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
