Github user ioana-delaney commented on a diff in the pull request:
https://github.com/apache/spark/pull/17546#discussion_r110076651
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala
---
@@ -150,12 +148,15 @@ object JoinReorderDP extends PredicateHelper with
Logging {
case (item, id) => Set(id) -> JoinPlan(Set(id), item, Set(), Cost(0,
0))
}.toMap)
+ // Build filters from the join graph to be used by the search
algorithm.
+ val filters = JoinReorderDPFilters(conf).buildJoinGraphInfo(items,
conditions, itemIndex)
+
// Build plans for next levels until the last level has only one plan.
This plan contains
// all items that can be joined, so there's no need to continue.
val topOutputSet = AttributeSet(output)
- while (foundPlans.size < items.length && foundPlans.last.size > 1) {
+ while (foundPlans.size < items.length) {
--- End diff --
@wzhfy Condition "foundPlans.last.size > 1" does not apply when filters
are used with the join enumeration since not all the plan combinations are
generated. Without filters, I think the condition will always be satisfied, so
I removed it completely. Let me know if you have a counter example.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
