Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17527#discussion_r110314541 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/CaseInsensitiveMap.scala --- @@ -26,11 +28,12 @@ package org.apache.spark.sql.catalyst.util class CaseInsensitiveMap[T] private (val originalMap: Map[String, T]) extends Map[String, T] with Serializable { - val keyLowerCasedMap = originalMap.map(kv => kv.copy(_1 = kv._1.toLowerCase)) + val keyLowerCasedMap = originalMap.map(kv => kv.copy(_1 = kv._1.toLowerCase(Locale.ROOT))) --- End diff -- Maybe nitpicking and it is rarely possible I guess. However, up to my knowledge, this will affect the options users set, `spark.read.option(...)`. Namely, I think these case possible as below: ```scala scala> java.util.Locale.setDefault(new java.util.Locale("tr")) scala> val originalMap = Map("ı" -> 1, "I" -> 2) originalMap: scala.collection.immutable.Map[String,Int] = Map(ı -> 1, I -> 2) ``` Before ```scala scala> originalMap.map(kv => kv.copy(_1 = kv._1.toLowerCase)) res6: scala.collection.immutable.Map[String,Int] = Map(ı -> 2) ``` After ```scala scala> originalMap.map(kv => kv.copy(_1 = kv._1.toLowerCase(java.util.Locale.ROOT))) res7: scala.collection.immutable.Map[String,Int] = Map(ı -> 1, i -> 2) ```
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org