Github user facaiy commented on a diff in the pull request:
https://github.com/apache/spark/pull/17556#discussion_r110386358
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala ---
@@ -996,7 +996,7 @@ private[spark] object RandomForest extends Logging {
require(metadata.isContinuous(featureIndex),
"findSplitsForContinuousFeature can only be used to find splits for
a continuous feature.")
- val splits = if (featureSamples.isEmpty) {
+ val splits: Array[Double] = if (featureSamples.isEmpty) {
--- End diff --
The code block is too long and has 4 exits. Emphasizing its type perhaps is
better to be understand, though `splits` is implied by return type.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
