Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/17577#discussion_r110549401
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameNaFunctions.scala ---
@@ -407,10 +407,11 @@ final class DataFrameNaFunctions private[sql](df:
DataFrame) {
val quotedColName = "`" + col.name + "`"
val colValue = col.dataType match {
case DoubleType | FloatType =>
- nanvl(df.col(quotedColName), lit(null)) // nanvl only supports
these types
+ // nanvl only supports these types
+ nanvl(df.col(quotedColName), lit(null).cast(col.dataType))
--- End diff --
The float one is covered by another test in `fill with map`, but still nice
to have them explicitly to avoid being changed unexpectedly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
