GitHub user jinxing64 opened a pull request:

    https://github.com/apache/spark/pull/17603

    [SPARK-20288] Avoid generating the MapStatus by stageId in 
BasicSchedulerIntegrationSuite

    ## What changes were proposed in this pull request?
    
    ShuffleId is determined before job submitted. But it's hard to predict 
stageId by shuffleId.
    Stage is created in DAGScheduler(
    
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala#L381),
 but the order is n
    ot determined.
    I added a log(println(s"Creating ShufflMapStage-$id on 
shuffle-${shuffleDep.shuffleId}")) after 
(https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala#L331),
 when testing BasicSchedulerIntegrationSuite:"multi-stage job". It will print:
    Creating ShufflMapStage-0 on shuffle-0
    Creating ShufflMapStage-1 on shuffle-2
    Creating ShufflMapStage-2 on shuffle-1
    Creating ShufflMapStage-3 on shuffle-3
    or
    Creating ShufflMapStage-0 on shuffle-1
    Creating ShufflMapStage-1 on shuffle-3
    Creating ShufflMapStage-2 on shuffle-0
    Creating ShufflMapStage-3 on shuffle-2
    It might be better to avoid generating the MapStatus by stageId.
    
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jinxing64/spark SPARK-20288

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/17603.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #17603
    
----
commit ea883f5d2b4bd63fae1f46bfe6ba78b352a894dc
Author: jinxing <jinxing6...@126.com>
Date:   2017-04-11T06:16:31Z

    [SPARK-20288] Avoid generating the MapStatus by stageId in 
BasicSchedulerIntegrationSuite

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to