Github user squito commented on the issue:

    https://github.com/apache/spark/pull/16781
  
    @ueshin thanks for taking a look earlier, sorry it has taken me some time 
to update this.
    
    Things to note since last time:
    
    1) Hive has seen been updated in 
[HIVE-16231](https://issues.apache.org/jira/browse/HIVE-16231) to use the local 
timezone, not GMT, as the default for storing data.  Really, this is the change 
that should have been in HIVE-12767 -- otherwise you lose backwards 
compatibility with old datasets.
    
    2) This PR now uses the session time zone, rather than local timezone.  
There are tests to confirm that a mix of session timezone X storage timezone 
works correctly.
    
    3) Predicate pushdown is handled.  I actually didn't need to change the 
behavior at all, since predicates are never pushed to int96 -- but there are 
some tests that confirm this.
    
    I'm sure there is some minor cleanup that could be done, but overall I 
think this is ready now.  I'd appreciate if you take another look and any 
suggestions you can make.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to