Github user lvdongr commented on a diff in the pull request:
https://github.com/apache/spark/pull/17620#discussion_r111337249
--- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala
---
@@ -539,7 +539,7 @@ private[deploy] class Master(
private def completeRecovery() {
// Ensure "only-once" recovery semantics using a short synchronization
period.
- if (state != RecoveryState.RECOVERING) { return }
+ if (state != RecoveryState.RECOVERING && state !=
RecoveryState.COMPLETING_RECOVERY) { return }
--- End diff --
Thank you for your review and suggest. The last change cannot work as I
tested today. I thought completeRecovery would be called again when some
workers or drivers response to MasterChanged, then the master(state is
RecoveryState.COMPLETING_RECOVERY) will have the chance to complete the
completeRecovery method and change state to ALIVE . I tested , but find no
called again after the exception(maybe workers or drivers already response to
MasterChanged before the exception).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
