Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/17469
  
    It looks good to me if it passes the test. I could request filling up other 
documentation as well but if it is difficult to run the tests in local machine 
and regarding (I assume) it is the very first contribution, I think it is 
probably fine.
    
    Maybe, I can make a followup to fill up all if all are fine here with it. I 
checked the documentation output manually before.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to