Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17636#discussion_r111542688
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1219,7 +1241,8 @@ class Analyzer(
// Make sure a plan's expressions do not contain outer references
def failOnOuterReference(p: LogicalPlan): Unit = {
- if (p.expressions.exists(containsOuter)) {
+ p.expressions.foreach(checkMixedReferencesInsideAggregation)
--- End diff --
`p` is not definitely an `Aggregate`, so I think
`checkMixedReferencesInsideAggregation` will not only apply to aggregate
expression.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
