Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17568#discussion_r111677163 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/objects.scala --- @@ -96,3 +98,23 @@ object CombineTypedFilters extends Rule[LogicalPlan] { } } } + +/** + * Removes MapObjects when the following conditions are satisfied + * 1. Mapobject(e) where e is lambdavariable(), which means types for input output + * are primitive types + * 2. no custom collection class specified + * representation of data item. For example back to back map operations. + */ +object EliminateMapObjects extends Rule[LogicalPlan] { + def apply(plan: LogicalPlan): LogicalPlan = plan transform { + case _ @ DeserializeToObject(Invoke( + MapObjects(_, _, _, Cast(LambdaVariable(_, _, dataType, _), castDataType, _), --- End diff -- I think `Cast` should be eliminated when running this rule?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org