Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17646#discussion_r111679940
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -1202,15 +1203,25 @@ class SessionCatalog(
def listFunctions(db: String, pattern: String): Seq[(FunctionIdentifier,
String)] = {
val dbName = formatDatabaseName(db)
requireDbExists(dbName)
- val dbFunctions = externalCatalog.listFunctions(dbName, pattern)
- .map { f => FunctionIdentifier(f, Some(dbName)) }
- val loadedFunctions =
StringUtils.filterPattern(functionRegistry.listFunction(), pattern)
- .map { f => FunctionIdentifier(f) }
+ val dbFunctions = externalCatalog.listFunctions(dbName, pattern).map {
f =>
+ FunctionIdentifier(f, Some(dbName)) }
+ val loadedFunctions =
+ StringUtils.filterPattern(functionRegistry.listFunction(),
pattern).map { f =>
+ // In functionRegistry, function names are stored as an unquoted
format.
+ Try(parser.parseFunctionIdentifier(f)) match {
+ case Success(e) => e
+ case Failure(_) =>
+ // The names of some built-in functions are not parsable by
our parser, e.g., %
+ FunctionIdentifier(f)
+ }
+ }
val functions = dbFunctions ++ loadedFunctions
--- End diff --
The name of persistent function exists in both `dbFunctions` and
`loadedFunctions`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
