Github user squito commented on the issue:

    https://github.com/apache/spark/pull/17656
  
    yeah, looks like the right change, I think it was just overlooked in 
https://issues.apache.org/jira/browse/SPARK-14245
    
    I'd ask that you add an assertion to this unit test: 
https://github.com/apache/spark/blob/master/core/src/test/scala/org/apache/spark/ui/UISeleniumSuite.scala#L655
    
    ```scala
    (attempts(0) \ "sparkUser").extract[String] should not be ("")
    ```
    
    aside, I'm not sure why SPARK-14245 introduced a different way of getting 
the user from what the history server uses, but in any case I think this change 
is right, to do the same thing as the UI, even if those internals should be 
changed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to