Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17636#discussion_r111833336
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
---
@@ -367,6 +367,8 @@ case class OuterReference(e: NamedExpression)
override def exprId: ExprId = e.exprId
override def toAttribute: Attribute = e.toAttribute
override def newInstance(): NamedExpression =
OuterReference(e.newInstance())
+ override def sql: String = e.sql
+ override def toString: String = e.toString
--- End diff --
Any reason to override this? If we keep it unchanged, will it be easier for
us to find whether it is an outer reference in the plans?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
