Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17660#discussion_r112117203
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala
---
@@ -134,8 +134,8 @@ case class EliminateOuterJoin(conf: SQLConf) extends
Rule[LogicalPlan] with Pred
val leftConditions =
conditions.filter(_.references.subsetOf(join.left.outputSet))
val rightConditions =
conditions.filter(_.references.subsetOf(join.right.outputSet))
- val leftHasNonNullPredicate = leftConditions.exists(canFilterOutNull)
- val rightHasNonNullPredicate = rightConditions.exists(canFilterOutNull)
+ lazy val leftHasNonNullPredicate =
leftConditions.exists(canFilterOutNull)
+ lazy val rightHasNonNullPredicate =
rightConditions.exists(canFilterOutNull)
--- End diff --
They are used three times in case statements. Inline version looks too
verbose.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
