Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17674#discussion_r112251255
  
    --- Diff: R/pkg/R/functions.R ---
    @@ -3652,3 +3652,56 @@ setMethod("posexplode",
                 jc <- callJStatic("org.apache.spark.sql.functions", 
"posexplode", x@jc)
                 column(jc)
               })
    +
    +#' create_array
    +#'
    +#' Creates a new array column. The input columns must all have the same 
data type.
    +#'
    +#' @param x Column to compute on
    +#' @param ... other columns
    +#'
    +#' @family collection_funcs
    --- End diff --
    
    perhaps that what it maps to in R, I haven't checked closely.
    though I'd think it'd be better to be consistent with Scala so they could 
be more easily discoverable.
    
    also I think we should change the `@family` name into full text instead of 
the short form some_funcs - that shows up in the generated doc. I didn't get 
around making all those changes but might make sense in the 2.3 release.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to