Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17693#discussion_r112584338
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -149,7 +149,7 @@ case class GetJsonObject(json: Expression, path:
Expression)
if (parsed.isDefined) {
try {
- Utils.tryWithResource(jsonFactory.createParser(jsonStr.getBytes))
{ parser =>
+ Utils.tryWithResource(jsonFactory.createParser(jsonStr.toString))
{ parser =>
--- End diff --
Keep the `jsonStr.getBytes` unchanged.
```Java
/**
* Method for constructing parser for parsing
* the contents of given byte array.
*
* @since 2.1
*/
public JsonParser createParser(byte[] data) throws IOException,
JsonParseException {
IOContext ctxt = _createContext(data, true);
if (_inputDecorator != null) {
InputStream in = _inputDecorator.decorate(ctxt, data, 0,
data.length);
if (in != null) {
return _createParser(in, ctxt);
}
}
return _createParser(data, 0, data.length, ctxt);
}
```
I think we should capture both `IOException` and `JsonParseException`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
