Github user zuotingbing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17638#discussion_r112597030
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -405,9 +405,7 @@ class SparkContext(config: SparkConf) extends Logging {
     
         _eventLogDir =
           if (isEventLogEnabled) {
    -        val unresolvedDir = conf.get("spark.eventLog.dir", 
EventLoggingListener.DEFAULT_LOG_DIR)
    -          .stripSuffix("/")
    -        Some(Utils.resolveURI(unresolvedDir))
    --- End diff --
    
    i suggest to use `new Path(path).toURI()` instead `new URI(path)` since 
`new URI(path)` not support space in path. 
    It is not necessary to use encode if we use `new Path(path).toURI()`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to